[draft, do not review] IBuildEngineCallbacks in taskhosts#12991
Draft
JanProvaznik wants to merge 14 commits intodotnet:mainfrom
Draft
[draft, do not review] IBuildEngineCallbacks in taskhosts#12991JanProvaznik wants to merge 14 commits intodotnet:mainfrom
JanProvaznik wants to merge 14 commits intodotnet:mainfrom
Conversation
JanProvaznik
changed the title
Member
Author
|
confirmed this can build wpf template and Roslyn.sln from the original issue 😏 |
7 tasks
JanProvaznik
added a commit
to JanProvaznik/msbuild
that referenced
this pull request
Jan 29, 2026
Implements callback infrastructure for TaskHost IBuildEngine callbacks: - Add packet type enum values for TaskHost callbacks (0x20-0x27 range) - Create ITaskHostCallbackPacket interface for request/response correlation - Add TaskHostQueryRequest/Response packets for property queries - Implement IsRunningMultipleNodes forwarding in OutOfProcTaskHostNode - Handle query requests in TaskHostTask (parent side) - Add integration tests for IsRunningMultipleNodes callback This enables tasks running in TaskHost to correctly query whether the build is running with multiple nodes, which is needed for multithreaded mode (-mt) support. Cherry-picked and adapted from PR dotnet#12991 (subtasks 1-2) Fixes part of dotnet#12863
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12863
#12868
Context
required for wpf support in multithreaded mode
Changes Made
split the plan to subtasks, attempted implementation by agents
Testing
includes unit and integration tests
Notes